In your first problem (Anchorage temp above NYC temp), you print x. But x is your looping index. So it always ends up as length(Temp_NYC) at the end of the loop.
It should be:
days = [];
c = 0;
for x=1:length(Temp_NYC)
if Temp_ACH(x)>TEMP_NYC(x)
c = c + 1;
days = [days; x];
end
end
fprintf('The number of days,... etc.')
fprintf('\n')
fprintf('%d\n', days)
The same goes for your second problem (Temp_ACH == Temp_NYC). I would suggest you use the same loop (just replace the > with ==).
I assume you are supposed to do it using a loop. If it doesn't matter how you solve it, here's a small tip: It is easier and faster to do it with logical indexing:
logical_index = Temp_NYC == Temp_ACH; % = "true" for days that had the same temperature and "false" for all that were different
days = find(logical_index); % The days: find() finds the "true" values and returns their indexes, which are equivalent to the days
num_days = length(days); % The number of days
P.S. Please don't send screenshots of your code. It is easier to analyse it if you copy and paste it into the forum and wrap it by selecting it and clicking on the {}Code button.
