Applying whos to each field of a struct
조회 수: 7 (최근 30일)
이전 댓글 표시
I wrote a function to apply the whos function to a struct and all of its fields recurvsively, and I have a strong but inarticulable feeling that either I've rewritten an existing Matlab function, or that i'm commiting bad code practice somehow (it is recursive, which always puts me a bit on guard), so while I don't have a specific question or problem, my general question is "Is this function bad in some way I don't see"
load("teststruct.mat")
[sinfo,sinfotable] = whosstruct(teststruct);
sinfotable
function [sinfo,sinfotable] = whosstruct(s,varargin)
if ~isstruct(s)
error('You must pass a struct')
end
if isempty(varargin)
upperlayername =inputname(1);
else
upperlayername = varargin{1};
end
sinfo = whos('s');
sinfo.name = upperlayername;
snames = fieldnames(s);
snames = cellfun(@string,snames);
for ii = 1:length(snames)
fldname = snames(ii);
sfield = s.(fldname);
sinfo(end+1) = whos('sfield');
sinfo(end).name = [upperlayername,'.',char(fldname)];
if isstruct(sfield)
subsinfo = whosstruct(sfield,sinfo(end).name);
sinfo = [sinfo,subsinfo];
end
end
sinfotable = struct2table(sinfo);
end
I intend to use this function to idenity the bottom levels of a struct which are large in memory compared to some threshold, like the image data of an image vs fields containing the pixel size of the camera and stuff like that. Then I can remove the fields that take up a bunch of space in memory and save the remaining fields which don't take as much space.
(By the way, is there standard language for refering to the parts a nested struct?)
Also, I think this is the first time i've taken advantage of Matlab Answers ability to add files and executable code, so any comments on how i've written this question are appreciated. I've attached a sample struct in teststruct.mat.
댓글 수: 1
Stephen23
2022년 5월 1일
Note that STRING will operate on a cell array of character vectors, so you can replace:
snames = cellfun(@string,snames);
with one STRING() call. But conversion to STRING type is superfluous anyway: you can simply use snames{ii} in the rest of the code and then get rid of CHAR too.
채택된 답변
Stephen23
2022년 5월 1일
편집: Stephen23
2022년 5월 1일
Using a nested function avoids the need for counting input arguments, simplifies the code somewhat, and might make collating the output easier. You should also consider non-scalar structures, even if only to throw an error for them.
load("teststruct.mat")
S = whosstruct(teststruct);
disp(struct2table(S))
function W = whosstruct(S)
assert(isstruct(S),'Input <S> must be a structure.')
assert(isscalar(S),'Input <S> must be scalar.')
W = whos('S');
W.name = inputname(1);
recfun(S,W.name)
%
function recfun(A,N)
F = fieldnames(A);
for k = 1:numel(F)
T = sprintf('%s.%s',N,F{k});
B = A.(F{k});
D = whos('B');
D.name = T;
W(end+1) = D;
if isstruct(B)
assert(isscalar(B),'Structure <%s> must be scalar.',T)
recfun(B,T)
end
end
end
end
댓글 수: 0
추가 답변 (1개)
Voss
2022년 4월 30일
The only problem with this that I see is that sub-structs get repeated in the output. See, e.g., 'teststruct.summary':
load("teststruct.mat")
[sinfo,sinfotable] = whosstruct(teststruct);
disp(sinfotable(strcmp(sinfotable.name,'teststruct.summary'),:))
One way to fix that is, instead of erroring-out when whosstruct is passed a non-struct, process its whos struct the same as you would a struct passed in. I've made that change and some other changes that don't really affect the behavior, in a new function whosstruct_new.
[sinfo_new,sinfotable_new] = whosstruct_new(teststruct);
disp(sinfotable_new(strcmp(sinfotable_new.name,'teststruct.summary'),:))
disp(sinfotable)
disp(sinfotable_new)
function [sinfo,sinfotable] = whosstruct_new(s,upperlayername)
if nargin < 2
upperlayername = inputname(1);
end
sinfo = setfield(whos('s'),'name',upperlayername);
if strcmp(sinfo.class,'struct')
snames = fieldnames(s);
snames_full = strcat(upperlayername,'.',snames);
for ii = 1:numel(snames)
sinfo = [sinfo,whosstruct_new(s.(snames{ii}),snames_full{ii})];
end
end
if nargout > 1
sinfotable = struct2table(sinfo);
end
end
function [sinfo,sinfotable] = whosstruct(s,varargin)
if ~isstruct(s)
error('You must pass a struct')
end
if isempty(varargin)
upperlayername =inputname(1);
else
upperlayername = varargin{1};
end
sinfo = whos('s');
sinfo.name = upperlayername;
snames = fieldnames(s);
snames = cellfun(@string,snames);
for ii = 1:length(snames)
fldname = snames(ii);
sfield = s.(fldname);
sinfo(end+1) = whos('sfield');
sinfo(end).name = [upperlayername,'.',char(fldname)];
if isstruct(sfield)
subsinfo = whosstruct(sfield,sinfo(end).name);
sinfo = [sinfo,subsinfo];
end
end
sinfotable = struct2table(sinfo);
end
댓글 수: 2
참고 항목
카테고리
Help Center 및 File Exchange에서 Structures에 대해 자세히 알아보기
Community Treasure Hunt
Find the treasures in MATLAB Central and discover how the community can help you!
Start Hunting!